[FFmpeg-devel] [PATCH] avfilter: add vr360 filter

Thilo Borgmann thilo.borgmann at mail.de
Mon Aug 5 22:16:02 EEST 2019


Am 05.08.19 um 21:16 schrieb Paul B Mahol:
> On Mon, Aug 5, 2019 at 9:12 PM Thilo Borgmann <thilo.borgmann at mail.de>
> wrote:
> 
>> Am 05.08.19 um 21:07 schrieb Paul B Mahol:
>>> On Mon, Aug 5, 2019 at 9:01 PM Thilo Borgmann <thilo.borgmann at mail.de>
>>> wrote:
>>>
>>>> Am 05.08.19 um 21:00 schrieb Paul B Mahol:
>>>>> On Mon, Aug 5, 2019 at 8:57 PM Thilo Borgmann <thilo.borgmann at mail.de>
>>>>> wrote:
>>>>>
>>>>>> Am 05.08.19 um 20:46 schrieb Eugene Lyapustin:
>>>>>>> Signed-off-by: Eugene Lyapustin <unishifft at gmail.com>
>>>>>>> ---
>>>>>>>  doc/filters.texi         |  137 +++
>>>>>>>  libavfilter/Makefile     |    1 +
>>>>>>>  libavfilter/allfilters.c |    1 +
>>>>>>>  libavfilter/vf_vr360.c   | 1847
>> ++++++++++++++++++++++++++++++++++++++
>>>>>>
>>>>>>
>>>>>>> +AVFilter ff_vf_vr360 = {
>>>>>>> +    .name          = "vr360",
>>>>>>> +    .description   = NULL_IF_CONFIG_SMALL("Convert 360 projection of
>>>>>> video."),
>>>>>>
>>>>>> "vr360" does not make any sense to me. VR and 360 degree are two
>>>> different
>>>>>> things.
>>>>>>
>>>>>> And since VR-related filters may very well emerge in the future, we
>>>> should
>>>>>> be as clear as possible about these.
>>>>>>
>>>>>
>>>>> Isnt VR just 360 but for each eye?
>>>>
>>>> That would be stereoscopic 360.
>>>>
>>>> What makes it VR is that the camera can move within space, not only
>> change
>>>> viewing direction.
>>>>
>>>
>>> Ah, than vr360 stands for Video processoR 360.
>>> What name should be instead?
>>
>> "mono360" could make sense if a "stereo360" would process two inputs (that
>> are not L-R or T-B coded)
>>
>> Or just "video360"... but we really should save us "vr" for the future.
>>
> 
> v360 then?

Works for me.

-Thilo


More information about the ffmpeg-devel mailing list