[FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

Marton Balint cus at passwd.hu
Mon Aug 5 00:54:16 EEST 2019



On Sun, 4 Aug 2019, Marton Balint wrote:

>>> @@ -1015,8 +1032,7 @@ static int mpegts_init(AVFormatContext *s)
>>> else
>>> av_log(s, AV_LOG_VERBOSE, "muxrate %d, ", ts->mux_rate);
>>>      av_log(s, AV_LOG_VERBOSE,
>>> -             "pcr every %d pkts, sdt every %d, pat/pmt every %d pkts\\n",
>>> -             service->pcr_packet_period,
>>> +             "sdt every %d, pat/pmt every %d pkts\\n",
>>>               ts->sdt_packet_period, ts->pat_packet_period);
>>
>> The information about the PCR interval is a must have. Please, don't remove 
> it!
>
> It is written out in select_pcr_streams.

Sorry, I had some version locally which did this, but not the current 
version. The PCR rework replaces this anyway with a fixed time based 
approach, so it does not really matter.

Regards,
Marton


More information about the ffmpeg-devel mailing list