[FFmpeg-devel] [PATCH] Revert "fate: add unit test for dnn-layer-pad"

Guo, Yejun yejun.guo at intel.com
Fri Aug 2 05:33:28 EEST 2019



> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> Hendrik Leppkes
> Sent: Thursday, August 01, 2019 11:14 PM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] Revert "fate: add unit test for
> dnn-layer-pad"
> 
> On Thu, Aug 1, 2019 at 4:53 PM Guo, Yejun <yejun.guo at intel.com> wrote:
> >
> > This reverts commit 3805aae47966b691f825abab6843f55676437a02.
> >
> > this test calls internal DNN functions within libavfilter, it is
> > not allowed, and so revert it.
> >
> 
> Its not that its not allowed, it just needs to be setup properly. We
> have for example the "checkasm" tests, which test internal modules
> which have no public API at all. You can check how that is setup.

got it, thanks Handrik, I'll use the same method as checkasm.

> 
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list