[FFmpeg-devel] [PATCH] Ticket #7124: Fixes compiler bug - replace vec_lvsl/vec_perm with vec_xl

Moritz Barsnick barsnick at gmx.net
Thu Aug 1 14:52:42 EEST 2019


Hi,

On Thu, Aug 01, 2019 at 07:42:28 -0400, ckerchne wrote:

Just a small hint: You patch was corrupted by newlines inserted by your
email client.

Try attaching the patch file, or using git send-email.

> > --- a/libswscale/ppc/yuv2rgb_altivec.c
> > +++ b/libswscale/ppc/yuv2rgb_altivec.c
> > @@ -305,9 +305,6 @@ static int altivec_ ## name(SwsContext *c, const
> > unsigned char **in,          \
> >      vector signed short R1, G1, B1;
> >        \
> >      vector unsigned char R, G, B;
> >        \
> >
> >        \
> > -    const vector unsigned char *y1ivP, *y2ivP, *uivP, *vivP;
> >        \
> > -    vector unsigned char align_perm;
> >        \
> > -
> >        \

See also here how the formatting ended up:
https://patchwork.ffmpeg.org/patch/14045/

Also please prefix the first line of the commit message with
"swscale/ppc/yuv2rgb_altivec:". The "Fixes #xxxx" part can go lower
into the commit message body (like to the last line, as a separate
parapgraph, for example).

Cheers,
Moritz

P.S.: I can't review this anyway. ;-)


More information about the ffmpeg-devel mailing list