[FFmpeg-devel] [PATCH v3] avfilter/avf_showwaves: Add draw mode also to showwavespic filter

[Paul B Mahol]

On 4/30/19, Martin Vobruba <vobruba.martin at gmail.com> wrote:
>> See commit a8c2d375ca68b7f001564ced14d8ac0757f53a29
>> ---
>>  doc/filters.texi            | 14 ++++++++++++++
>>  libavfilter/avf_showwaves.c |  3 +++
>>  2 files changed, 17 insertions(+)
>>
>> diff --git a/doc/filters.texi b/doc/filters.texi
>> index e9cbccc..2aabe8a 100644
>> --- a/doc/filters.texi
>> +++ b/doc/filters.texi
>> @@ -22645,6 +22645,20 @@ Cubic root.
>>  @end table
>> Default is linear.
>> +
>> + at item draw
>> +Set the draw mode.
>> +
>> +Available values are:
>> + at table @samp
>> + at item scale
>> +Scale pixel values for each drawn sample.
>> +
>> + at item full
>> +Draw every sample directly.
>> + at end table
>> +
>> +Default value is @code{scale}.
>>  @end table
>> @subsection Examples
>> diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
>> index 0e683cf..a0d2b25 100644
>> --- a/libavfilter/avf_showwaves.c
>> +++ b/libavfilter/avf_showwaves.c
>> @@ -765,6 +765,9 @@ static const AVOption showwavespic_options[] = {
>>          { "log", "logarithmic",    0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_LOG}, .flags=FLAGS, .unit="scale"},
>>          { "sqrt", "square root",   0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_SQRT}, .flags=FLAGS, .unit="scale"},
>>          { "cbrt", "cubic root",    0, AV_OPT_TYPE_CONST,
>> {.i64=SCALE_CBRT}, .flags=FLAGS, .unit="scale"},
>> +    { "draw", "set draw mode", OFFSET(draw_mode), AV_OPT_TYPE_INT,
>> {.i64 = DRAW_SCALE}, 0, DRAW_NB-1, FLAGS, .unit="draw" },
>> +        { "scale", "scale pixel values for each drawn sample", 0,
>> AV_OPT_TYPE_CONST, {.i64=DRAW_SCALE}, .flags=FLAGS, .unit="draw"},
>> +        { "full",  "draw every pixel for sample directly",     0,
>> AV_OPT_TYPE_CONST, {.i64=DRAW_FULL},  .flags=FLAGS, .unit="draw"},
>>      { NULL }
>>  };
>>
>
> Any feedback please?

Was applied.