[FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

[Li, Zhong]

> > But the CODE doesn't say that!
> >
> > The code uses:
> > "#if QSV_HAVE_CO3"
> >
> > And then every use of the "co3" member needs to be protected by this
> clausule.
> > Futhermore, this is true in every part of the source code in
> > "qsvenc.c"... except at two points (I need to review my patch, as I noticed
> another block not protected).
> >
> > This is a must, even if "QSV_VERSION_ATLEAST(1, 18)" >
> "QSV_VERSION_ATLEAST(1, 11)"
> >
> > Why?
> > Because the option "QSV_HAVE_CO3" can be rewriten (for example,
> disabled).

I don't think so.
It is pre-compile checking and should not be decided in FFmpeg level, indstead depended on MSDK API has defined it or not.