[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

James Almer jamrial at gmail.com
Mon Apr 29 02:34:13 EEST 2019


On 4/28/2019 7:59 PM, Mark Thompson wrote:
> On 17/04/2019 03:56, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Better macro names welcome. I used the same convention as in cbs_av1.
>>
>> fate-cbs passes, but i'm sure a bunch of these are not tested by it,
>> so help double checking i didn't screw up is welcome.
>>
>>  libavcodec/cbs_h2645.c                |  10 +-
>>  libavcodec/cbs_h264_syntax_template.c |  60 ++++++------
>>  libavcodec/cbs_h265_syntax_template.c | 126 +++++++++++---------------
>>  3 files changed, 90 insertions(+), 106 deletions(-)
> 
> The cleanup to things with nontrivial length expressions is nice :)
> 
> LGTM.
> 
> Thanks,
> 
> - Mark

Pushed, thanks!


More information about the ffmpeg-devel mailing list