[FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

[James Almer]

On 4/18/2019 9:12 PM, Dan Sanders via ffmpeg-devel wrote:
> Fixes: UBSan runtime error
> Found-by: Clusterfuzz
> ---
>  libavformat/apetag.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/apetag.c b/libavformat/apetag.c
> index cdc602e1a9..2991f57d5d 100644
> --- a/libavformat/apetag.c
> +++ b/libavformat/apetag.c
> @@ -29,10 +29,10 @@
>  #include "apetag.h"
>  #include "internal.h"
> 
> -#define APE_TAG_FLAG_CONTAINS_HEADER  (1 << 31)
> -#define APE_TAG_FLAG_LACKS_FOOTER     (1 << 30)
> -#define APE_TAG_FLAG_IS_HEADER        (1 << 29)
> -#define APE_TAG_FLAG_IS_BINARY        (1 << 1)
> +#define APE_TAG_FLAG_CONTAINS_HEADER  (1U << 31)

Isn't it enough with this one only?

> +#define APE_TAG_FLAG_LACKS_FOOTER     (1U << 30)
> +#define APE_TAG_FLAG_IS_HEADER        (1U << 29)
> +#define APE_TAG_FLAG_IS_BINARY        (1U << 1)
> 
>  static int ape_tag_read_field(AVFormatContext *s)
>  {
>