[FFmpeg-devel] [PATCH v2 2/3] lavc: Add coded bitstream read/write support for AV1

[Mark Thompson]

On 18/09/18 01:25, James Almer wrote:
> On 9/17/2018 8:47 PM, Mark Thompson wrote:
>> ---
>> On 10/09/18 20:14, Michael Niedermayer wrote:
>>> breaks build on mips:
>>> CC	libavcodec/av1_metadata_bsf.o
>>> In file included from src/libavcodec/av1_metadata_bsf.c:25:
>>> src/libavcodec/cbs_av1.h:364: warning: declaration does not declare anything
>>> src/libavcodec/cbs_av1.h:380: warning: declaration does not declare anything
>>> ... lots of errors because of anonymous unions ...
>>
>> Fixed by giving these unions redundant names.  Anonymous unions would be nice, but they're probably a little too much trouble still for old compilers.
> 
> I think GCC 4.8, used in CentOS, had trouble with those as well. But at
> some point we should probably just set the minimum version to something
> like GCC 4.9 (First version with C11 atomics). It would probably
> simplify a lot of code beyond just anonymous unions.

Or worse - RedHat/CentOS 6 is still supported by them, with GCC 4.4.

While I do think it's sensible that these old versions still work where reasonable, I agree that it might be worth reassessing what is actually useful to support in the not-too-distant future.  Moving to C11 in general isn't possible because Microsoft, but I think there are very few people who would be inconvenienced by the version requirement being bumped on the GCC/Clang side of things.

>> ...
> 
> Looks good now. Thanks!

Great.  Does anyone else have any comments?  I'll push this in two days if there isn't anything further.

Thanks,

- Mark