[FFmpeg-devel] [PATCH] avformat/matroskaenc: add reserve free space option
James Darnley
james.darnley at gmail.com
Thu Sep 6 22:18:50 EEST 2018
On 2018-09-06 19:39, Sigríður Regína Sigurþórsdóttir wrote:
> + if (s->metadata_header_padding) {
> + if (s->metadata_header_padding == 1)
> + s->metadata_header_padding++;
> + put_ebml_void(pb, s->metadata_header_padding);
> + }
Unfortunately I was forced to make the default -1 so you want to check
that the value is greater than 0 rather than just true.
Furthermore I think you will still want to add to Changelog making a
note that the matroska muxer will now listen to metadata_header_padding.
That may also want a micro version bump so that library users can check.
More information about the ffmpeg-devel
mailing list