[FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

Ronak Patel ronak2121 at yahoo.com
Wed Oct 31 02:07:00 EET 2018


> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 
> 2018-10-27 20:50 GMT+02:00, Mark Thompson <sw at jkqxz.net>:
>> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df.
>> 
>> The additional braces cause build errors with Linux headers earlier
>> than 4.5 because the first element of the structure was not originally
>> a union.
> 
>> Not sure what compiler was warning about these, but it's definitely
>> incorrect for it to do so.
> 
> Must have been NDK clang.

This fix isn’t enough for this. The references to the variables in the union fail to compile. This doesn’t fix that.


> 
> Sorry, Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



More information about the ffmpeg-devel mailing list