[FFmpeg-devel] [PATCH 2/2] libx264: Pass the reordered_opaque field through the encoder

[Martin Storsjö]

On Tue, 30 Oct 2018, Derek Buitenhuis wrote:

> On 29/10/2018 21:06, Martin Storsjö wrote:
>> As I guess there can be old frames in flight, the only safe option is to
>> enlarge, not to shrink it. But in case a realloc moves the array, the old
>> pointers end up pretty useless.
>
> Just always allocate the max (which is known for H.264), and adjust nb_reordered_opaque
> as need be, on reconfig, no?

Hmm, that might make sense, but with a little twist. The max reordered 
frames for H.264 is known, but onto that you also get more delay due to 
frame threads and other details that this function within x264 knows 
about. So that would make it [H264 max reordering] + [threads] + 
[constant] or something such?

// Martin