[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve XMA missing samples

Banana M. bananaman255 at gmail.com
Sat Oct 27 12:45:19 EEST 2018


> You can set final number of samples in output frame directly:
> frame->nb_samples = X.

I was told I shouldn't do that (even though other codecs do it?). I quote:
>> No, this is wrong. Codecs don't need to do this manually, this is done by
>> libavcodec/decode.c, based on the packet's AV_PKT_DATA_SKIP_SAMPLES side
data.

I think it would also have problems with xma_decode_packet since it only
works with 512 nb_samples.

So I hope this can patch accepted as-is and then it can be refined in later
patches.


More information about the ffmpeg-devel mailing list