[FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

[Baptiste Coudurier]

Hey guys,

On Tue, Oct 23, 2018 at 4:42 PM James Almer <jamrial at gmail.com> wrote:

> On 10/23/2018 8:15 PM, Dale Curtis wrote:
> > On Fri, Oct 19, 2018 at 4:50 PM James Almer <jamrial at gmail.com> wrote:
> >
> >> +    s.n_tile_threads = dav1d->tile_threads;
> >> +    s.n_frame_threads = dav1d->frame_threads;
> >>
> >
> > Did you consider using the AVCodecContext.threads value along
> > AVCodecContext.thread_type flags? That seems to be how this is handled
> > elsewhere.
> >
> > - dale
>
> I did, but with the library offering options for both tiles or frames i
> wasn't sure if choosing one or the other was a good idea.
> I could map avctx->thread_count to n_frame_threads and leave the other
> as a decoder specific option, i guess, but with the current API there's
> no single optimal way for auto threads.


Agree. We should map them. Can we add frame type tiles ?

-- 
Baptiste Coudurier