[FFmpeg-devel] [PATCH] libavdevice/libndi_newtek: Added extra_ips option to libndi_newtek allowing use remote network sources

Marton Balint cus at passwd.hu
Fri Oct 26 23:27:51 EEST 2018



On Fri, 26 Oct 2018, Moritz Barsnick wrote:

> On Fri, Oct 26, 2018 at 11:16:02 +0300, Anton Platov wrote:
>> +    { "extra_ips", "Find available sources on extra ip addresses",       OFFSET(extra_ips), AV_OPT_TYPE_STRING, {.str = NULL }, 0, 0, DEC },
>                       ^
>
> This makes it sound like a boolean option (i.e. whether to find). In
> reality, you want a comma separated string of IP addresses[1]. You
> should say so, e.g.
>
> "Extra IP addresses to find available sources on (comma separated)".

Also please update docs/indev.texi with the new option.

Thanks,
Marton


More information about the ffmpeg-devel mailing list