[FFmpeg-devel] [PATCH] avfilter: add xstack filter

[Lou Logan]

On Wed, Oct 24, 2018, at 11:04 AM, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/filters.texi         |  45 ++++++++++++
>  libavfilter/Makefile     |   1 +
>  libavfilter/allfilters.c |   1 +
>  libavfilter/vf_stack.c   | 151 ++++++++++++++++++++++++++++++++++++---
>  4 files changed, 187 insertions(+), 11 deletions(-)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 740eec670c..51e6a0fc1c 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -17798,6 +17798,51 @@ Set the scaling dimension: @code{2} for 
> @code{2xBR}, @code{3} for
>  Default is @code{3}.
>  @end table
>  
> + at section xstack
> +Stack video inputs into custom layout.
> +
> +All streams must be of same pixel format.
> +
> +The filter accept the following option:
> +
> + at table @option
> + at item inputs
> +Set number of input streams. Default is 2.
> +
> + at item layout
> +Specify layout of inputs. This option needs to be always set.

This option requires the desired layout configuration to be explicitly set by the user.

> +This sets position of each video input in output. Each input
> +is separated by '|'. First number represents column and second row,
> +numbers are separated by '_'.

This sentence is confusing and can be made clearer by breaking it apart:

  The first number represents the column, and the second number represents the row.
  Numbers start at 0 and are separated by '_'.

Everything else LGTM.