[FFmpeg-devel] [PATCH] avformat/mxfenc: simplify dnxhd handling and add more flavors

[Tomas Härdin]

tis 2018-10-23 klockan 14:04 -0700 skrev Baptiste Coudurier:
> Hey Tomas,
> 
> On Mon, Oct 22, 2018 at 12:52 PM Tomas Härdin <tjoppen at acc.umu.se>
> wrote:
> 
> > mån 2018-10-22 klockan 11:37 -0700 skrev Baptiste Coudurier:
> > > ---
> > >  libavformat/mxfenc.c | 215 ++++++++++++-------------------------
> > > ------
> > >  1 file changed, 61 insertions(+), 154 deletions(-)
> > > 
> > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > index f6acf80d36..71a9b97bed 100644
> > > --- a/libavformat/mxfenc.c
> > > +++ b/libavformat/mxfenc.c
> > > +    sc->codec_ul = NULL;
> > > +    cid = AV_RB32(pkt->data + 0x28);
> > > +    for (i = 0; i < FF_ARRAY_ELEMS(mxf_dnxhd_codec_uls); i++)
> > > +        if (cid == mxf_dnxhd_codec_uls[i].cid) {
> > > +            sc->codec_ul = &mxf_dnxhd_codec_uls[i].codec_ul;
> > > +            break;
> > > +        }
> > 
> > Maybe put braces around the for
> > 
> > Nice work!
> > 
> 
> Ok, I will put the braces. I should be applying this later today.

Sounds fine to me

/Tomas