[FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

[Zhou, Zachary]

Good point, and I find in the build script configure can do function "XDisplayName" check when checking to enable vaapi. 

resent the patch. 

-----Original Message-----
From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Hendrik Leppkes
Sent: Tuesday, October 23, 2018 8:56 PM
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

On Tue, Oct 23, 2018 at 2:00 PM Zachary Zhou <zachary.zhou at intel.com> wrote:
>
> Reproduce the issue:
>
> $ ./configure --enable-libmfx --enable-vaapi --enable-shared 
> --samples=fate-suite/ $ make fate
> LD      tests/checkasm/checkasm
> /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'XDisplayName'
> //usr/lib/x86_64-linux-gnu/libX11.so.6: error adding symbols: DSO 
> missing from command line
> collect2: error: ld returned 1 exit status
> tests/checkasm/Makefile:71: recipe for target 
> 'tests/checkasm/checkasm' failed
> make: *** [tests/checkasm/checkasm] Error 1
> ---
>  tests/checkasm/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 
> 9484acbbd7..d4827dc816 100644
> --- a/tests/checkasm/Makefile
> +++ b/tests/checkasm/Makefile
> @@ -66,6 +66,7 @@ OBJDIRS += $(CHECKASMDIRS)
>  tests/checkasm/checkasm.o: CFLAGS += -Umain
>
>  CHECKASM := tests/checkasm/checkasm$(EXESUF)
> +EXTRALIBS += -lX11
>
>  $(CHECKASM): $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS)
>         $(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(CHECKASMOBJS) 
> $(FF_STATIC_DEP_LIBS) $(EXTRALIBS-avcodec) $(EXTRALIBS-avfilter) 
> $(EXTRALIBS-avformat) $(EXTRALIBS-avutil) $(EXTRALIBS-swresample) 
> $(EXTRALIBS)
> --
> 2.17.1
>

Shouldn't this be automatically coming in through EXTRALIBS-avutil?

- Hendrik
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel