[FFmpeg-devel] [PATCH]lavc/sinewin: Do not declare tables as const

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Oct 15 00:51:13 EEST 2018


2018-10-14 22:30 GMT+02:00, Hendrik Leppkes <h.leppkes at gmail.com>:
> On Sun, Oct 14, 2018 at 10:18 PM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
>>
>> Attached patch is supposed to fix ticket #7491, I currently
>> don't have gcc 8 to test myself.
>
> Only the 120 and 960 tables are affected by this bug because
> they are not being created by the hardcoded tables logic, yet
> this patch changes the const attribute for all tables, defeating
> one purpose of the hardcoded tables.

> Can we adjust this to only affect the two tables that need it

Did that in attached patch, please comment.

> or remove hardcoded tables for sinewin entirely, instead of leaving
> them half-baked, or add 120 and 960 to hardcoded tables generation?

Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-sinewin-Do-not-declare-AAC-120-960-tables-as-co.patch
Type: text/x-patch
Size: 2488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181014/d9c28a08/attachment.bin>


More information about the ffmpeg-devel mailing list