[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

[Banana M.]

> No, you need to set this during init.
> You should also set avctx->delay to the same value.

This value is part of the bitstream, so theoretically can appear in any
packet after the first. Can you confirm it doesn't?

How could it be set on init? You'd need to read the bitstream then rewind?
And what if there are multiple skips in different packets?


> Usually true? Decoders aren't usually true, they're always true.

Usually true as those values are optional yet common, there is an "if"
right below.


> No, this is wrong. Codecs don't need to do this manually, this is done by
> libavcodec/decode.c, based on the packet's AV_PKT_DATA_SKIP_SAMPLES side
> data.

All code with  AV_PKT_DATA_SKIP_SAMPLES I see imply the use of
av_packet_new_side_data and look like it'd need many changes, how should it
be done?


> This is confusing, you should split the patches affecting different
codecs.

XMA and WMAPRO are the same codec with minor configs differences, it seemed
redundant to do 2 patches forcing 2 reviews of the same thing.