[FFmpeg-devel] [PATCH 5/5] libavfilter/ebur128: add mabsolute parameter

[Daniel Molkentin]

On 07.10.2018 21:37, Marton Balint wrote:
>
>
> On Sun, 7 Oct 2018, Daniel Molkentin wrote:
>
>>
>> On 07.10.2018 18:02, Daniel Molkentin wrote:
>>> This allows switching between absolute (LUFS) and relativ (LU) display
>>> in the status line.
>>>
>>> Signed-off-by: Daniel Molkentin <daniel at molkentin.de>
>>> Signed-off-by: Conrad Zelck <c.zelck at imail.de>
>>> ---
>>>  doc/filters.texi        |  4 ++++
>>>  libavfilter/f_ebur128.c | 34 +++++++++++++++++++++++++---------
>>>  2 files changed, 29 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/doc/filters.texi b/doc/filters.texi
>>> index 601cbda17c..dc01c805b2 100644
>>> --- a/doc/filters.texi
>>> +++ b/doc/filters.texi
>>> @@ -19371,6 +19371,10 @@ by EBU R128. However, material published
>>> online may prefer a level of -16LUFS
>>>  Set the value displayed by the gauge. Valid values are m
>>> (momentary) and s (short-term).
>>>  By default the momentary value will be used, but in certain
>>> scenarios it may be more useful
>>>  to observe the short term value instead (e.g. live mixing).
>>> +
>>> + at item mabsolute
>>> +Sets whether to display the loudness in LUFS (1, the default) LU
>>> relative to the target (0).
>>> +This only affects the video output, not the summary or continous
>>> log output.
>>>  @end table
>>>
>> On a second thought, should this maybe be measurement=absolute|relative
>> or measurement=LU|LUFS? Opinions? More descriptive that way...
>
> scale=absolute/relative
>
> IMHO that makes it the most descriptive.
We thought about that, but the first association we thought people might
have when confronted with the word scale are the histogram labels with
the LU values on the right, (which are untouched by this option). I am
fine with either.

Cheers,
  Daniel