[FFmpeg-devel] [PATCH] avcodec/wmaprodec: improve WMAPRO/XMA gapless output

[Michael Niedermayer]

On Wed, Oct 03, 2018 at 11:55:32PM +0200, bananaman255 at gmail.com wrote:
> From: bnnm <bananaman255 at gmail.com>

Is it intended that this doesnt list a human name ?
(its no problem but jb tends to be unhappy if there are no names in the log
 so i try to ask people if they really intend to not list their name or if
 its a unintended mistake)
 


> 
> Improves trac issue #6722. Fixes truncated XMA output (was missing 128 samples) and applies bitstream gapless info (partially for XMA, fully for WMAPRO).
> 
> Applying XMA end_skip would require some extra changes in the XMA multi-stream handling, so end samples are slightly bigger than what should be.
> 
> Compared to MS's decoders, WMAPRO in XWMA are correct, while in ASF (.wma) don't seem to read the last frame, so output is around 128~512 samples smaller (this happens even with gapless disabled and affects other ASF codecs).
> 
> Signed-off-by: bnnm <bananaman255 at gmail.com>
> ---
>  libavcodec/wmaprodec.c | 92 ++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 66 insertions(+), 26 deletions(-)

this will need some change to 
TEST    wmapro-ism
stddev:    0.00 PSNR:143.22 MAXDIFF:    1 bytes:   884736/   879952
size: |884736 - 879952| >= 0
Test wmapro-ism failed. Look at tests/data/fate/wmapro-ism.err for details.
make: *** [fate-wmapro-ism] Error 1


[..]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181005/651361af/attachment.sig>