[FFmpeg-devel] [FFmpeg-devel, 1/2] lavu/qsv: fix a random hwupload failure regression

Rogozhkin, Dmitry V dmitry.v.rogozhkin at intel.com
Fri Oct 5 19:23:38 EEST 2018


On Sun, 2018-09-30 at 17:15 +0800, Zhong Li wrote:
> Variable 'ret' hasn't been initialized,thus introducing a random
> hwupload failure regression due to qsv session uninitialized.
> 
> Signed-off-by: Zhong Li <zhong.li at intel.com>
> ---
>  libavutil/hwcontext_qsv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c
> index cb3e184..33e121b 100644
> --- a/libavutil/hwcontext_qsv.c
> +++ b/libavutil/hwcontext_qsv.c
> @@ -861,7 +861,7 @@ static int qsv_transfer_data_to(AVHWFramesContext
> *ctx, AVFrame *dst,
>  
>      mfxSyncPoint sync = NULL;
>      mfxStatus err;
> -    int ret;
> +    int ret = 0;
>  
>      while (!s->session_upload_init && !s->session_upload && !ret) {
>  #if HAVE_PTHREADS

Works on my side and fixes an issue with hwupload which I saw. Can,
please, this be merged?



More information about the ffmpeg-devel mailing list