[FFmpeg-devel] [PATCH] lavfi/vf_colorconstancy: add weighted_greyedge

[Mina]

On 10/01/2018 12:24 PM, Moritz Barsnick wrote:
>> +The standard deviation of Gaussian blur to be applied on the scene. Must be
>                                                           ^ to
>

Done.

>> +The power applied to the weight map to emphasis heigher weights. Must be chosen
>                                            ^ emphasize

British spelling but done.

>> +The angular error threshold in degrees for stoping the algorithm. Must be chosen
>                                                ^ stopping
>

Done.

>> + * @cite
>> + *  J. van de Weijer, Th. Gevers, and J. Geusebroek,
>> + * ???Edge and corner detection by photometric quasi-invariants???.
>        ^^^
> You should fix the quotation marks here.

Done.

>> - * @return 0 in case of success, a negative value corresponding to an
>> - * AVERROR code in case of failure.
>> + * @return 0.
>>    */
>> -static int filter_grey_edge(AVFilterContext *ctx, AVFrame *in)
>> +static int filter_slice_weighted_grey_edge(AVFilterContext* ctx, void* arg, int jobnr, int nb_jobs)
> If it only ever returns 0, you can probably make it void - unless it
> will be expanded later to require a return code.

AVFilterInternal::execute expects such type of the function.

>
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel