[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

Paul B Mahol onemda at gmail.com
Mon Oct 1 10:37:01 EEST 2018


On 9/30/18, Nicolas George <george at nsup.org> wrote:
> Paul B Mahol (2018-09-30):
>> > For consistency within a single function, an assert is the correct
>> > choice.
>> No, it is not. Asserts do not add any consistency.
>
> Asserts do not add consistency indeed. Their purpose is to check
> consistency, which is exactly what needs testing here: the consistency
> between the preliminary test and the later switch statement.
>
> If you want to argue for AVERROR_BUG, please give arguments.

Same is given with AVERROR_BUG, instead of hard crashing with assert, which is
very unprofessional.


More information about the ffmpeg-devel mailing list