[FFmpeg-devel] [PATCH] configure: use -r, not -E, for sed

Lauri Kasanen cand at gmx.com
Sat Nov 17 09:50:00 EET 2018


On Fri, 16 Nov 2018 22:36:16 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2018-11-15 15:00 GMT+01:00, Lauri Kasanen <cand at gmx.com>:
> > Old versions of sed do not support the -E option.
> 
> > -        VERSION_SCRIPT_POSTPROCESS_CMD='tr " " "\n" | sed -n
> > /global:/,/local:/p | grep ";" | tr ";" "\n" | sed -E "s/(.+)/_\1/g" | sed
> > -E "s/(.+[^*])$$$$/\1*/"'
> > +        VERSION_SCRIPT_POSTPROCESS_CMD='tr " " "\n" | sed -n
> > /global:/,/local:/p | grep ";" | tr ";" "\n" | sed -r "s/(.+)/_\1/g" | sed
> > -r "s/(.+[^*])$$$$/\1*/"'
> 
> Could you try to replace the current command with one that
> neither needs "-E" nor "-r"?
> Your suggestions fixes antique Linux systems but not current
> non-Linux Posix systems (and contradicts the documentation).

Regexes tend to be write-only. Not sure I can parse what that tries to
do, to rewrite it in basic RE that posix sed supports.

What do you mean by contradicts docs?

- Lauri


More information about the ffmpeg-devel mailing list