[FFmpeg-devel] [PATCH v2] hwcontext_vaapi: Add option to set driver name

Michael Niedermayer michael at niedermayer.cc
Thu Nov 15 13:38:22 EET 2018


On Wed, Nov 14, 2018 at 09:25:00PM +0000, Mark Thompson wrote:
> For example: -init_hw_device vaapi:/dev/dri/renderD128,driver=foo
> 
> This may be more convenient that using the environment variable, and allows
> loading different drivers for different devices in the same process.
> ---
> On 14/11/18 12:05, Michael Niedermayer wrote:
> > On Wed, Nov 14, 2018 at 12:21:07AM +0000, Mark Thompson wrote:
> >> ...
> >> +        vas = vaSetDriverName(display, driver->value);
> > 
> > this breaks build here on ubuntu:
> > 
> > CC	libavutil/hwcontext_vaapi.o
> > libavutil/hwcontext_vaapi.c: In function ‘vaapi_device_create’:
> > libavutil/hwcontext_vaapi.c:1537:9: error: implicit declaration of function ‘vaSetDriverName’ [-Werror=implicit-function-declaration]
> >          vas = vaSetDriverName(display, driver->value);
> >          ^
> > cc1: some warnings being treated as errors
> > make: *** [libavutil/hwcontext_vaapi.o] Error 1
> > make: Target `all' not remade because of errors.
> 
> Ah, apologies - that API is newer than I thought.
> 
> Here's a new version with suitable guards.

works here, thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181115/9caa40bb/attachment.sig>


More information about the ffmpeg-devel mailing list