[FFmpeg-devel] [PATCH] hwcontext_vaapi: Add option to set driver name

[Michael Niedermayer]

On Wed, Nov 14, 2018 at 12:21:07AM +0000, Mark Thompson wrote:
> For example: -init_hw_device vaapi:/dev/dri/renderD128,driver=foo
> 
> This may be more convenient that using the environment variable, and allows
> loading different drivers for different devices in the same process.
> ---
>  libavutil/hwcontext_vaapi.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> index 8624369bb9..eb3a78d181 100644
> --- a/libavutil/hwcontext_vaapi.c
> +++ b/libavutil/hwcontext_vaapi.c
> @@ -1469,6 +1469,8 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
>  {
>      VAAPIDevicePriv *priv;
>      VADisplay display = NULL;
> +    const AVDictionaryEntry *driver;
> +    VAStatus vas;
>  
>      priv = av_mallocz(sizeof(*priv));
>      if (!priv)
> @@ -1530,6 +1532,17 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device,
>          return AVERROR(EINVAL);
>      }
>  
> +    driver = av_dict_get(opts, "driver", NULL, 0);
> +    if (driver) {
> +        vas = vaSetDriverName(display, driver->value);

this breaks build here on ubuntu:

CC	libavutil/hwcontext_vaapi.o
libavutil/hwcontext_vaapi.c: In function ‘vaapi_device_create’:
libavutil/hwcontext_vaapi.c:1537:9: error: implicit declaration of function ‘vaSetDriverName’ [-Werror=implicit-function-declaration]
         vas = vaSetDriverName(display, driver->value);
         ^
cc1: some warnings being treated as errors
make: *** [libavutil/hwcontext_vaapi.o] Error 1
make: Target `all' not remade because of errors.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181114/61ac3e84/attachment.sig>