[FFmpeg-devel] [PATCH 1/2] lavu: add locale-independent sscanf implementation

Tomas Härdin tjoppen at acc.umu.se
Tue Nov 13 18:58:07 EET 2018


tis 2018-11-13 klockan 12:47 +0100 skrev Paul B Mahol:
> On 11/13/18, Tomas Härdin <tjoppen at acc.umu.se> wrote:
> > mån 2018-11-12 klockan 21:41 +0100 skrev Nicolas George:
> > > Tomas Härdin (2018-11-12):
> > > > Why not set locale instead?
> > > 
> > > That would conflict with the wishes of the application. A library
> > > should
> > > never change global state.
> > > 
> > > (Of course, the core of the problem is that locales are global
> > > state,
> > > this is braindead design.)
> > 
> > So fork() instead. This is a horrible solution
> 
> Look at rest of functions, we already have av_isspace and etc.
> And saying its horrible solution is disgrace to me.

That was probably uncalled for, sorry. It just irks me how awful libc
is that one should have to reimplement everything it does..

/Tomas


More information about the ffmpeg-devel mailing list