[FFmpeg-devel] Implement muxing AAC in a CAFF container

[Carl Eugen Hoyos]

2018-11-10 4:31 GMT+01:00, Lewis Fox <lrflew.coll at gmail.com>:

> I originally planned on putting a shared function for writing the elementary
> stream descriptor in mov_esds.c, along side the function that reads the
> elementary stream descriptor. However, the implementation in movenc.c used
> the MOVTrack class, which wouldn't easily be usable by the CAFF encoder.

Why not?

> I ended up copying the function into cafenc.c

If it can be avoided, please do not copy the function.

[...]

> I also included a small, related change in this commit. Put simply, the CAFF
> magic cookie doesn't contain the version+flags field that the MPEG ESDS
> section has, but it was still trying to be read by ff_mov_read_esds. I moved
> that field to mov_read_esds, which fixes reading the magic cookie when
> demuxing CAFF files.

Please split this patch out, are there no unexpected side-effects?

Carl Eugen