[FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

Eran Kornblau eran.kornblau at kaltura.com
Wed May 30 08:39:50 EEST 2018


> 
> 
> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Michael Niedermayer
> Sent: Wednesday, May 30, 2018 12:37 AM
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop
> 
> > +                *ptr++ = (current_offset >> 56) & 0xFF;
> > +                *ptr++ = (current_offset >> 48) & 0xFF;
> > +                *ptr++ = (current_offset >> 40) & 0xFF;
> > +                *ptr++ = (current_offset >> 32) & 0xFF;
> > +                *ptr++ = (current_offset >> 24) & 0xFF;
> > +                *ptr++ = (current_offset >> 16) & 0xFF;
> > +                *ptr++ = (current_offset >>  8) & 0xFF;
> > +                *ptr++ = (current_offset >>  0) & 0xFF;
> 
> can this be simplfified with
> libavcodec/bytestream.h, libavutil/intreadwrite.h or similar ?
> 
> [...]
> 

Yes, I can change it to AV_WB32/AV_WB64, but at the moment this utility is completely stand-alone - 
it does not depend on anything from ffmpeg, so maybe it's better to keep it this way.

Thanks

Eran

> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Modern terrorism, a quick summary: Need oil, start war with country that has oil, kill hundread thousand in war. Let country fall into chaos, be surprised about raise of fundamantalists. Drop more bombs, kill more people, be surprised about them taking revenge and drop even more bombs and strip your own citizens of their rights and freedoms. to be continued
>


More information about the ffmpeg-devel mailing list