[FFmpeg-devel] [PATCH 2/2] cmdutils: dump HWAccel type in print_codec()

[Mark Thompson]

On 26/05/18 14:14, Jun Zhao wrote:
> dump the hwaccel type for codec when use the command like
> ./ffmpeg -h decoder=h264.
> 
> Signed-off-by: Jun Zhao <mypopydev at gmail.com>
> ---
>  fftools/cmdutils.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 4f2e0a2..eeee14b 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1444,6 +1444,17 @@ static void print_codec(const AVCodec *c)
>          printf("\n");
>      }
>  
> +    if (avcodec_get_hw_config(c, 0)) {
> +        printf("    HWAccel devices: ");

These aren't necessarily for hwaccel, they can be hardware-only too.

Perhaps "Supported hardware devices:"?

> +        for (int i = 0;; i++) {
> +            const AVCodecHWConfig *config = avcodec_get_hw_config(c, i);
> +            if (!config)
> +                break;
> +            printf("%s ", av_hwdevice_get_type_name(config->device_type));
> +        }
> +        printf("\n");
> +    }
> +
>      if (c->supported_framerates) {
>          const AVRational *fps = c->supported_framerates;
>  
> 

Otherwise looks fine - good idea to make it show this information.

Thanks,

- Mark