[FFmpeg-devel] [PATCH 12/13] avformat/mxfenc: Add Stored F2 Offset / Image Start/End Offset for D10

[Michael Niedermayer]

On Tue, May 08, 2018 at 12:58:09PM +0200, Tomas Härdin wrote:
> mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >          desc_size += 8;
> >      if (st->codecpar->color_range != AVCOL_RANGE_UNSPECIFIED)
> >          desc_size += 8 * 3;
> > +    if (s->oformat == &ff_mxf_d10_muxer)
> > +        desc_size += 8 + 8 + 8;
> >  
> >      mxf_write_generic_desc(s, st, key, desc_size);
> >  
> > @@ -1169,6 +1173,20 @@ static void mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const UID ke
> >      mxf_write_local_tag(pb, 4, 0x3202);
> >      avio_wb32(pb, stored_height>>sc->interlaced);
> >  
> > +    if (s->oformat == &ff_mxf_d10_muxer) {
> > +        //Stored F2 Offset
> > +        mxf_write_local_tag(pb, 4, 0x3216);
> > +        avio_wb32(pb, 0);
> > +
> > +        //Image Start Offset
> > +        mxf_write_local_tag(pb, 4, 0x3213);
> > +        avio_wb32(pb, 0);
> > +
> > +        //Image End Offset
> > +        mxf_write_local_tag(pb, 4, 0x3214);
> > +        avio_wb32(pb, 0);
> > +    }
> 
> Looks OK, but of course I don't know what the spec says

double checked, "Table A1- CDCI (Picture) Essence Descriptor" lists 0 for these

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/6a4bbfbf/attachment.sig>