[FFmpeg-devel] [PATCH 03/13] avformat/mxfenc: Add Product Version, Toolkit version and Platform

[Michael Niedermayer]

On Tue, May 08, 2018 at 12:28:48PM +0200, Tomas Härdin wrote:
> mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >  static void mxf_write_identification(AVFormatContext *s)
> >  {
> >      MXFContext *mxf = s->priv_data;
> > @@ -790,7 +809,7 @@ static void mxf_write_identification(AVFormatContext *s)
> >  
> >      version = s->flags & AVFMT_FLAG_BITEXACT ?
> >          "0.0.0" : AV_STRINGIFY(LIBAVFORMAT_VERSION);
> > -    length = 72 + mxf_utf16_local_tag_length(company) +
> > +    length = 100 +mxf_utf16_local_tag_length(company) +
> 
> I have mixed feelings about this style of computation. But not enough
> to hold the patch up, which looks OK

ok, will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/bf4ce3b5/attachment.sig>