[FFmpeg-devel] [PATCH] lavf/bluray: translate a read of 0 to EOF

wm4 nfxjfg at googlemail.com
Sun May 6 17:32:06 EEST 2018


On Sun,  6 May 2018 17:19:44 +0300
Jan Ekström <jeebjp at gmail.com> wrote:

> Yet another case of forgotten 0 =! EOF translation. The libbluray
> documentation specifically mentions that a read of 0 is EOF.
> 
> Reported by Fyr on IRC.
> ---
>  libavformat/bluray.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/bluray.c b/libavformat/bluray.c
> index 9282bf9956..635c4f1b87 100644
> --- a/libavformat/bluray.c
> +++ b/libavformat/bluray.c
> @@ -198,7 +198,7 @@ static int bluray_read(URLContext *h, unsigned char *buf, int size)
>  
>      len = bd_read(bd->bd, buf, size);
>  
> -    return len;
> +    return len == 0 ? AVERROR_EOF : len;
>  }
>  
>  static int64_t bluray_seek(URLContext *h, int64_t pos, int whence)

Hilarious, another of those EOf issues. Too bad we didn't just revert
that crap. I wonder how many years it'll take until we got all of them.

LGTM.


More information about the ffmpeg-devel mailing list