[FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu May 3 00:36:30 EEST 2018


2018-05-02 23:23 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
> On 2 May 2018 at 21:19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
>> 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
>> > On 1 May 2018 at 21:58, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> >
>> >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
>> >> > Its a reminder of a bygone era. Less flexible than the internal RC
>> >> > system, probably worse and most definitely broken. Drop it. No one
>> >> > ever used it either, except for mislead people.
>> >>
>> >> Sorry for my bad git knowledge:
>> >> Is the above part of the commit message?
>> >>
>> >> Carl Eugen
>>
>> > Yep, its part of the commit message.
>>
>> Then the patch cannot be committed as-is.
>>
>
> Why?
>
>
>
>> Please wait for a comment from the maintainer, Carl Eugen
>>
>
> So if the maintainer approves I can commit as is?

No, of course not, the commit message is offensive.
Just remove the "reasoning".

Carl Eugen


More information about the ffmpeg-devel mailing list