[FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

[Rostislav Pehlivanov]

On 1 May 2018 at 20:00, Rostislav Pehlivanov <atomnuker at gmail.com> wrote:

>
>  {"ibias", "intra quant bias",
>  FF_MPV_OFFSET(intra_quant_bias), AV_OPT_TYPE_INT, {.i64 =
> FF_DEFAULT_QUANT_BIAS }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS },   \
>  {"pbias", "inter quant bias",
>  FF_MPV_OFFSET(inter_quant_bias), AV_OPT_TYPE_INT, {.i64 =
> FF_DEFAULT_QUANT_BIAS }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS },   \
> -{"rc_strategy", "ratecontrol method",
>  FF_MPV_OFFSET(rc_strategy), AV_OPT_TYPE_INT, {.i64 =
> MPV_RC_STRATEGY_FFMPEG }, 0, NB_MPV_RC_STRATEGY-1, FF_MPV_OPT_FLAGS,
> "rc_strategy" },   \
> -    { "ffmpeg", "default native rate control", 0, AV_OPT_TYPE_CONST, {
> .i64 = MPV_RC_STRATEGY_FFMPEG }, 0, 0, FF_MPV_OPT_FLAGS, "rc_strategy" }, \
> -    { "xvid",   "libxvid (2 pass only)",       0, AV_OPT_TYPE_CONST, {
> .i64 = MPV_RC_STRATEGY_XVID },   0, 0, FF_MPV_OPT_FLAGS, "rc_strategy" }, \
> +{"rc_strategy", "ratecontrol method",
>  FF_MPV_OFFSET(rc_strategy), AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 1,
> FF_MPV_OPT_FLAGS, "rc_strategy" },   \
> +    { "ffmpeg", "deprecated, does nothing", 0, AV_OPT_TYPE_CONST, { .i64
> = 0 }, 0, 0, FF_MPV_OPT_FLAGS, "rc_strategy" }, \
> +    { "xvid",   "deprecated, does nothing", 0, AV_OPT_TYPE_CONST, { .i64
> = 0 }, 0, 0, FF_MPV_OPT_FLAGS, "rc_strategy" }, \
>
>
Locally changed to use the new AV_OPT_FLAG_DEPRECATED flag:
+{"rc_strategy", deprecated, does nothing", FF_MPV_OFFSET(rc_strategy),
AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 1, FF_MPV_OPT_FLAGS |
AV_OPT_FLAG_DEPRECATED, "rc_strategy" },   \
+    { "ffmpeg", "deprecated, does nothing", 0, AV_OPT_TYPE_CONST, { .i64 =
0 }, 0, 0, FF_MPV_OPT_FLAGS | AV_OPT_FLAG_DEPRECATED, "rc_strategy" }, \
+    { "xvid",   "deprecated, does nothing", 0, AV_OPT_TYPE_CONST, { .i64 =
0 }, 0, 0, FF_MPV_OPT_FLAGS | AV_OPT_FLAG_DEPRECATED, "rc_strategy" }, \