[FFmpeg-devel] [PATCH] movtextenc: fix handling of utf-8 subtitles

[Philip Langdale]

On Wed, 28 Mar 2018 13:14:57 +0200
wm4 <nfxjfg at googlemail.com> wrote:

> On Wed, 28 Mar 2018 14:02:04 +0300
> Andrey Turkin <andrey.turkin at gmail.com> wrote:
> 
> > I think first check (ascii case) should be explicit bit-test, or
> > (if there is some reason to use sign-bit approach) at least "c"
> > should be signed char instead of simply char.  
> 
> Good point actually. It relies on char signedness, which is not
> guaranteed.

Fair point. I'm updating it.

--phil