[FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs
michael at niedermayer.cc
Sun Mar 25 17:41:12 EEST 2018
On Sun, Mar 25, 2018 at 03:32:33PM +0200, Nicolas George wrote:
> Josh de Kock (2018-03-23):
> You can observe just that by the fact that you needed to add an avpriv
> function to let lavd communicate with lavf. Each time an avpriv function
> appears, it shows there is something flawed in the design.
If this is true, in general, then we can improve designs by removing
avpriv_* functions ...
looking at what we have as avprivs, in the tree, i think some of these
could be indeed usefull as public APIs. And we need to already keep them
compatible as they are exported as avpriv too, so making such changes does
indeed in some cases look like a good idea to me
There are some avprivs we have currently though that are quite specific
to format intgernals, i dont think that its always a flaw to use avpriv
but i think we should evaluate each of the currently existing avpriv
functions and check if the API wouldnt be usefull to user applications.
And if it wouldnt be better to make it properly public
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel