[FFmpeg-devel] [PATCH] avfilter/af_pan: parse properly expressions referencing the same channel multiple times

Nicolas George george at nsup.org
Sun Mar 25 16:36:24 EEST 2018

Marton Balint (2018-03-24):
> Fixes parsing of expressions like c0=c0+c0. Previously no error was thrown and
> only the last gain factor was used.
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavfilter/af_pan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding that misfeature. But I think your fixes goes in the
wrong direction. I think that "c1=c1+c1" is much more likely to be a
typo for "c1=c1+c4" than an intentional way of writing "c1=2*c1".
Therefore I think it would be better to return an error, or at least
print a warning, than accepting it silently.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180325/27fb179c/attachment.sig>

More information about the ffmpeg-devel mailing list