[FFmpeg-devel] Type mismatch in ADPCM
michael at niedermayer.cc
Sat Mar 24 13:00:51 EET 2018
On Sat, Mar 24, 2018 at 11:10:41AM +0100, Carlo Bramini wrote:
> > > > > However, what about the patch attached for fixing the declaration
> > > > > of ff_adpcm_afc_coeffs?
> > > >
> > > > This would revert 10542491, a relatively recent change: Maybe Paul,
> > > > the author, wants to comment.
> > > >
> > > > Do you think the code gets more readable?
> > >
> > > Excuse me... I was just wondering what to do
> > You could answer above question.
> I'm sorry, I was thinking that you did the question to Mr. Paul, since you were requesting a comment from him.
> For me, I would say that this change makes the code more correct rather than more readable, which should be a more important reason, but that's just my opinion.
then please submit a proper git patch with that.
people may have missed this change due to the more exciting extern C++ stuff
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
"I am not trying to be anyone's saviour, I'm trying to think about the
future and not be sad" - Elon Musk
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel