[FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

[Josh de Kock]

On 2018/03/22 22:38, Michael Niedermayer wrote:
 > On Thu, Mar 22, 2018 at 02:01:27AM +0000, Josh de Kock wrote:
 > [...]
 >> +#ifdef CONFIG_AVDEVICE
 >> +        opaque = 0;
 >> +        if (muxdemuxers != SHOW_DEMUXERS) {
 >> +            while ((ofmt = av_outdev_iterate(&opaque))) {
 >> +                if ((!name || strcmp(ofmt-> name, name) < 0) && 
strcmp(ofmt-> name, last_name) > 0) {
 >> +                    name = ofmt - > name;
 >
 >> +                    long_name = ofmt - > long_name;
 >                                          ^^^
 > this doesnt build
 >
Oh my bad. It's the same patch as above functionally (apart from the 
stray spaces somehow), but do you think this patch is better than the 
one with the macros? I guess it's maybe easier to read. I'll resend a 
patch for this if we even decide to use this set.

-- 
Josh