[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

[Alexander Strasser]

On 2018-03-22 16:04 +0100, Nicolas George wrote:
> Paul B Mahol (2018-03-22):
> > So user can pick which channels to extract.
> > 
> > Signed-off-by: Paul B Mahol <onemda at gmail.com>
> > ---
> >  doc/filters.texi              | 18 ++++++++++++++++++
> >  libavfilter/af_channelsplit.c | 39 +++++++++++++++++++++++++++++++++------
> >  2 files changed, 51 insertions(+), 6 deletions(-)
> 
> Thanks for simplifying the code. I have no more remarks. But Alexander
> commented too, so please let him time to follow-up.

I still think checking the number of channels to be less then or
equal to the size of map is more robust.

There are two things that could change in future

1. the size of map (for whatever reason; maybe someone thinks 16
channels are max or similar...)
2. the number of channels we support could be increased

As each channel is represented by a bit in a 64 bit integer, it seems
kind of unlikely we get more channels soon. So I won't insist on the
check to be added.

Patch LGTM.


Thank you,
  Alexander