[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option
george at nsup.org
Wed Mar 21 22:43:34 EET 2018
Paul B Mahol (2018-03-21):
> I have legitimate technical concert about your faulty review.
Seriously, have you no pride at all for the quality of your code?
Personally, I would feel ashamed to publish that code, let alone defend
it if somebody points the flaw to me.
> There is log message which is incompatible with whatever you propose.
The log message only happens if a channel is present in
extracted_channels but not channel_layout. It cannot happen if
extracted_channels = channel_layout.
Seriously, the ONLY thing you need to do is set extracted_channels to
the same value as channel_layout instead of parsing it if it is "all".
Absolutely nothing more.
> So from now on I'm pushing patches like this without review,
> expecially one frome you.
Then I'll revert and request that your commit rights be revoked.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: Digital signature
More information about the ffmpeg-devel