[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option
george at nsup.org
Wed Mar 21 22:31:29 EET 2018
Paul B Mahol (2018-03-21):
> It is hardly identical, and I can not read your mind.
More than half the block is identical to the previous one.
> And it is functionally incompatible.
I told you how you can factor it.
> Enough bikesheds from you!
This is a legitimate technical concern: duplicated code is bad,
duplicated that is that easy to factor is unacceptable. Enhance your
code or drop the patch, but do not apply as is.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: Digital signature
More information about the ffmpeg-devel