[FFmpeg-devel] [PATCH v3 3/7] cmdutils: use new iteration APIs

[Nicolas George]

Josh de Kock (2018-03-19):
> +        x(av_muxer_iterate, ofmt, muxdemuxers != SHOW_DEMUXERS && !device_only);
> +        x(av_demuxer_iterate, ifmt, muxdemuxers != SHOW_MUXERS && !device_only);
> +#if CONFIG_AVDEVICE
> +        x(av_outdev_iterate, ofmt, muxdemuxers != SHOW_DEMUXERS);
> +        x(av_indev_iterate, ifmt, muxdemuxers != SHOW_MUXERS);
> +#endif
> +#undef x

Nack.

If applications need to do that kind of stunt to enumerate devices, they
will not bother doing it, thus losing features in a few unusual cases
and reducing the testing coverage of lavd by users.

Since indevs and demuxers behave the same way and outdevs and muxers
ditto, the default API need to return them all once.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180319/160922e5/attachment.sig>