[FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao
yingmingfan at gmail.com
Mon Mar 19 06:41:05 EET 2018
Hi, is there any review about this patch? What’s your option about wrapper we used in this patch.
> On 11 Mar 2018, at 8:59 PM, Yingming Fan <yingmingfan at gmail.com> wrote:
>> On 11 Mar 2018, at 8:54 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2018-03-08 8:03 GMT+01:00 Yingming Fan <yingmingfan at gmail.com>:
>>> From: Meng Wang <wangmeng.kids at bytedance.com>
>>> + stride_dst /= sizeof(uint8_t);
>>> + stride_src /= sizeof(uint8_t);
>> FFmpeg requires sizeof(uint8_t) to be 1, please simplify
>> your patch accordingly.
>> Why is the wrapper function needed?
> We use wrapper because codes in wrapper no need to be written with assembly, C codes more readable.
>> Carl Eugen
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel