[FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter
Carl Eugen Hoyos
ceffmpeg at gmail.com
Sun Mar 18 20:36:35 EET 2018
2018-03-18 19:12 GMT+01:00, Mark Thompson <sw at jkqxz.net>:
> On 16/03/18 15:06, Carl Eugen Hoyos wrote:
>> 2018-03-16 8:33 GMT+01:00, dylanf123 at gmail.com <dylanf123 at gmail.com>:
>>> From: drfer3 <drfer3 at student.monash.edu>
>>> --- /dev/null
>>> +++ b/libavfilter/opencl/avgblur.cl
>>> @@ -0,0 +1,60 @@
>>> + * This file is part of FFmpeg.
>> Please add your name.
> Is there some specific reason for wanting it in this case?
Nothing specifically, it is just a good idea.
(You may even interpret it as an insurance.)
> I prefer not to add it and would weakly encourage others
> not to (though I realise that many people do like to add it),
Sounds like a really horrible suggestion and I wonder
where you got it from.
> because it is often inaccurate when multiple people
> touch a file.
So you argue that because some people did not add
their copyright statements (because they know it is not
necessary) we should forbid contributors to add them?
> The only source for anyone actually needing authorship
> information should be the commit history.
FFmpeg is a superb example for a project where looking
at the commit history is not sufficient to find out about
authorship (this is just to explain that there are different,
not necessarily closely related issues at hand).
More information about the ffmpeg-devel