[FFmpeg-devel] [PATCH 1/4] checkasm/Makefile: add EXTRALIBS-libavformat

Josh de Kock josh at itanimul.li
Sun Mar 18 19:38:46 EET 2018


On Sun, Mar 18, 2018 at 01:42:12PM -0300, James Almer wrote:
> On 3/18/2018 1:06 PM, Paul B Mahol wrote:
> > [...]
> > And how do you know that?, without even providing alternative?
> 
> I provided an alternative. Look at my comment about the *_FFLIBS
> variables. The build system already uses it when linking the libraries
> themselves.
> The build system has a lot of measures to only build the required
> objects and only link the required libraries based on configure time
> options. Hardcoding avformat and swresample extralibs for this
> executable when avcodec and avfilter may be built without the modules
> that require said libraries is doing the exact opposite of that.

I will look into the *_FFLIBS variables. I figured it would be an OK
patch because of the swresample one recently added.

> Sure, we can commit this as a "temporary" fix, seeing that something
> needs to be done in a timely manner so the iterate() api can be
> committed, but the result will be that nobody will bother to implement
> it right afterwards.

This would be preferred, or at least looking at the other patches first
as they are more complex. This is an issue which can be looked at after
all the other major issues are discussed, the main one being:

How avdevice and avformat interact going forward (see the v2 of the patch
which removes a bunch of register_all() functions for an explanation
of this issue).

-- 
Josh



More information about the ffmpeg-devel mailing list