[FFmpeg-devel] fate/hap : add test for hap encoding

[Martin Vignali]

2018-03-14 1:48 GMT+01:00 James Almer <jamrial at gmail.com>:

> On 3/13/2018 4:31 PM, Martin Vignali wrote:
> > 2018-03-11 19:37 GMT+01:00 Martin Vignali <martin.vignali at gmail.com>:
> >
> >>
> >>
> >> 2017-11-26 18:25 GMT+01:00 Martin Vignali <martin.vignali at gmail.com>:
> >>
> >>> Hello,
> >>>
> >>> Patch in attach, add test for hap encoding (currently not cover) (patch
> >>> 002)
> >>> and move decoding tests to a separate file (patch 001)
> >>>
> >>> decoding can be test with
> >>> make fate-hap SAMPLES=fate-suite/
> >>>
> >>> and encoding can be test with
> >>> make fate-hapenc SAMPLES=fate-suite/
> >>>
> >>> Hap encoding need ffmpeg compile with libsnappy (--enable-libsnappy)
> >>>
> >>>
> >> If noone is against,
> >> i plan to apply this in few days.
> >>
> >> In attach, updated patch (in order to apply it on master).
> >>
> >> Martin
> >>
> >>
> > Pushed.
> >
> > Martin
>
> These tests are failing
> http://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-
> enableshared&time=20180313201913
>
> I'm with Carl, there's a reason we don't tests wrappers using external
> libraries. The output for such tests is unpredictable and depends on a
> lot of external factors we can't control, so please remove these tests.
>


In that case we can let the test using "none" compression (bypass the
snappy part)
and remove only snappy1 and snappy16 test
Like in patch in attach.

Please apply, if it's ok, i will can't do it soon.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fate-hapenc-remove-test-which-use-libsnappy.patch
Type: application/octet-stream
Size: 7438 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180314/1511c2de/attachment.obj>